From 1de61e8e4d4916927f099e572395c44965bb1f15 Mon Sep 17 00:00:00 2001
From: mwiegand <martin.wiegand@seibert.group>
Date: Sun, 17 May 2026 17:05:17 +0200
Subject: [PATCH] refactor(files): drop the always-True download_supported flag
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

download_supported was set to True at every call site (3 templates, 2
route render calls) and never to False. The {% set show_download =
download_supported and not entry.broken %} branch in
_overlay_file_node.html was therefore equivalent to {% set
show_download = not entry.broken %}, and {% set has_actions =
(files_overlay or show_download) and not entry.broken %} simplifies
further: when not broken, both clauses make has_actions True
regardless of files_overlay; when broken, both clauses make it False.
So has_actions = not entry.broken.

Collapsed:
  * Removed download_supported = True from overlay_detail.html (×2),
    server_detail.html, and the two render_template calls in
    files_routes.py
  * Removed the show_download intermediate and the inner {% if
    show_download %} guard in _overlay_file_node.html (the surrounding
    {% if has_actions %} already guarantees not entry.broken)
  * has_actions now directly equals not entry.broken

If a future requirement actually wants per-overlay download-disable,
re-introduce a flag at that point with a real callsite that sets it
False (and a test that exercises that path).

pytest: 577 passed, 1 skipped, 3 deselected — unchanged. None of the
existing tests gated on download_supported.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 l4d2web/l4d2web/routes/files_routes.py            | 2 --
 l4d2web/l4d2web/templates/_overlay_file_node.html | 5 +----
 l4d2web/l4d2web/templates/overlay_detail.html     | 2 --
 l4d2web/l4d2web/templates/server_detail.html      | 1 -
 4 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/l4d2web/l4d2web/routes/files_routes.py b/l4d2web/l4d2web/routes/files_routes.py
index 2d4340c..951fb26 100644
--- a/l4d2web/l4d2web/routes/files_routes.py
+++ b/l4d2web/l4d2web/routes/files_routes.py
@@ -129,7 +129,6 @@ def overlay_files_fragment(overlay_id: int):
         truncated=truncated_count > 0,
         truncated_count=truncated_count,
         files_base_url=f"/overlays/{overlay_id}",
-        download_supported=True,
         files_overlay=(overlay.type == "files"),
     )
 
@@ -195,7 +194,6 @@ def server_files_fragment(server_id: int):
         truncated=truncated_count > 0,
         truncated_count=truncated_count,
         files_base_url=f"/servers/{server_id}",
-        download_supported=True,
     )
 
 
diff --git a/l4d2web/l4d2web/templates/_overlay_file_node.html b/l4d2web/l4d2web/templates/_overlay_file_node.html
index 571c430..b3691db 100644
--- a/l4d2web/l4d2web/templates/_overlay_file_node.html
+++ b/l4d2web/l4d2web/templates/_overlay_file_node.html
@@ -18,8 +18,7 @@
   <div class="file-tree-children" hidden></div>
 </li>
 {% else %}
-{% set show_download = download_supported and not entry.broken %}
-{% set has_actions = (files_overlay or show_download) and not entry.broken %}
+{% set has_actions = not entry.broken %}
 <li class="file-tree-row file-tree-row-file{% if has_actions %} files-row{% endif %}"
     {% if files_overlay %}draggable="true" data-target-path="{{ entry.rel }}" data-row-kind="file" data-editable="{{ '1' if entry.editable else '0' }}"{% endif %}>
   {% if entry.broken %}
@@ -36,9 +35,7 @@
   {% endif %}
   {% if has_actions %}
   <span class="files-row-actions" aria-label="File actions">
-    {% if show_download %}
     <a class="files-row-action" href="{{ files_base_url }}/files/download?path={{ entry.rel|urlencode }}" title="Download">⬇</a>
-    {% endif %}
     {% if files_overlay %}
     <button type="button" class="files-row-action files-row-danger" data-action="delete" data-target-path="{{ entry.rel }}" data-row-kind="file" data-row-name="{{ entry.name }}" title="Delete">✕</button>
     {% endif %}
diff --git a/l4d2web/l4d2web/templates/overlay_detail.html b/l4d2web/l4d2web/templates/overlay_detail.html
index 6ca1fb1..4ffa616 100644
--- a/l4d2web/l4d2web/templates/overlay_detail.html
+++ b/l4d2web/l4d2web/templates/overlay_detail.html
@@ -90,7 +90,6 @@
             {% set truncated = file_tree_truncated %}
             {% set truncated_count = file_tree_truncated_count %}
             {% set files_base_url = "/overlays/" ~ overlay.id %}
-            {% set download_supported = True %}
             {% set files_overlay = True %}
             {% include "_overlay_file_tree.html" %}
           {% endif %}
@@ -106,7 +105,6 @@
     {% set truncated = file_tree_truncated %}
     {% set truncated_count = file_tree_truncated_count %}
     {% set files_base_url = "/overlays/" ~ overlay.id %}
-    {% set download_supported = True %}
     {% include "_overlay_file_tree.html" %}
   {% endif %}
   {% endif %}
diff --git a/l4d2web/l4d2web/templates/server_detail.html b/l4d2web/l4d2web/templates/server_detail.html
index 5716824..a0654e5 100644
--- a/l4d2web/l4d2web/templates/server_detail.html
+++ b/l4d2web/l4d2web/templates/server_detail.html
@@ -71,7 +71,6 @@
     {% set truncated = file_tree_truncated %}
     {% set truncated_count = file_tree_truncated_count %}
     {% set files_base_url = "/servers/" ~ server.id %}
-    {% set download_supported = True %}
     {% include "_overlay_file_tree.html" %}
   {% endif %}
 </section>