From 5e2c771276898c8247d8e867950b2f0b5447e58b Mon Sep 17 00:00:00 2001
From: mwiegand <martin.wiegand@seibert.group>
Date: Fri, 8 May 2026 17:25:15 +0200
Subject: [PATCH] chore(l4d2-web): remove orphaned 'Global map overlays' admin
 section

The route /admin/global-overlays/refresh was removed with the script-overlays
rewrite (migration 0005 dropped the global_overlay_* tables; the systemd
refresh units were deleted from deploy/). The admin-page form was left
behind and would 404 on submit. Drop the section and lock it out with an
assertion in the existing admin-pages test.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 l4d2web/templates/admin.html | 9 ---------
 l4d2web/tests/test_pages.py  | 5 ++++-
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/l4d2web/templates/admin.html b/l4d2web/templates/admin.html
index 7a8dfdd..f0eea62 100644
--- a/l4d2web/templates/admin.html
+++ b/l4d2web/templates/admin.html
@@ -28,13 +28,4 @@
     <button type="submit">Refresh all workshop items</button>
   </form>
 </section>
-
-<section class="panel">
-  <h2>Global map overlays</h2>
-  <p class="muted">Queue a refresh for managed L4D2Center and CEDAPUG map overlays.</p>
-  <form method="post" action="/admin/global-overlays/refresh">
-    <input type="hidden" name="csrf_token" value="{{ session.get('csrf_token', '') }}">
-    <button type="submit">Refresh global overlays</button>
-  </form>
-</section>
 {% endblock %}
diff --git a/l4d2web/tests/test_pages.py b/l4d2web/tests/test_pages.py
index 2f7d530..5685924 100644
--- a/l4d2web/tests/test_pages.py
+++ b/l4d2web/tests/test_pages.py
@@ -312,7 +312,10 @@ def test_admin_can_use_admin_pages(tmp_path, monkeypatch) -> None:
 
     admin_page = client.get("/admin")
     assert admin_page.status_code == 200
-    assert 'action="/admin/install"' in admin_page.get_data(as_text=True)
+    admin_html = admin_page.get_data(as_text=True)
+    assert 'action="/admin/install"' in admin_html
+    assert "/admin/global-overlays/refresh" not in admin_html
+    assert "Global map overlays" not in admin_html
     assert client.get("/admin/users").status_code == 200
     jobs_response = client.get("/admin/jobs")
     assert jobs_response.status_code == 200