cronekorkn/left4me
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test(files): cover filename-rename on save

Browse source 
Opens server.cfg, changes the filename input to server-renamed.cfg,
clicks Save, and asserts: the routed modal closes, the old name is
gone from disk, the new name carries the original content, and the
tree row swaps over. Pins the rename-on-save branch in
routedSaveClicked (the non-is_new path that diffs originalLeaf vs
editedFilename and emits `new_path`).

Deliberately omits __filesEditor.setContent — rename should preserve
the textarea-seeded content. A regression that wrote an empty body
fails on the content-equality assertion.

Tier 1 complete: 7 tests + fixture extension. Full suite runs in
<10s on warm Chromium.

Per docs/superpowers/plans/2026-05-17-files-overlay-e2e-handoff.md.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
mwiegand 2026-05-17 18:46:40 +02:00
parent 3ea57b2bdb
commit 81ba4ac83a
No known key found for this signature in database
1 changed files with 47 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
l4d2web/tests/e2e/test_files_overlay.py
View file

@ -336,3 +336,50 @@ def test_new_folder_then_delete(page: Page, files_overlay_server) -> None:
assert not (overlay_root / folder_name).exists() assert not (overlay_root / folder_name).exists()
# The tree refresh removes the row. # The tree refresh removes the row.
expect(folder_row).to_have_count(0, timeout=5000) expect(folder_row).to_have_count(0, timeout=5000)
def test_filename_rename_on_save(page: Page, files_overlay_server) -> None:
"""Open server.cfg, change the filename input to server-renamed.cfg,
and click Save. The single POST /files/save call performs an atomic
rename + write; the test asserts the disk reflects both the new
name and the original content, AND that the tree row swaps over.
This pins the rename-on-save branch in routedSaveClicked (the
non-is_new code path that diffs originalLeaf vs editedFilename
and emits `new_path`). A regression that dropped the rename
payload would silently leave the original file in place — the
"old name gone" + "new name present" assertion pair catches that.
We do NOT call __filesEditor.setContent here: the rename should
preserve the original textarea-seeded content. If the save handler
accidentally writes an empty body, the content-equality assertion
fails.
"""
base = files_overlay_server["base_url"]
overlay_id = files_overlay_server["overlay_id"]
overlay_root = files_overlay_server["overlay_root"]
original_content = (overlay_root / "server.cfg").read_text()
_open_overlay(page, base, overlay_id)
page.click('button.file-tree-name-button[data-target-path="server.cfg"]')
_wait_for_routed_editor(page)
new_name = "server-renamed.cfg"
page.fill("input[data-editor-filename]", new_name)
page.click(".files-editor-save")
expect(page.locator("#modal-container")).to_be_hidden(timeout=5000)
# Disk: old name gone, new name present with the original content.
assert not (overlay_root / "server.cfg").exists()
assert (overlay_root / new_name).read_text() == original_content
# Tree refresh runs at parentOf(new_path) = "" (root) — both rows
# come from that same listing, so we wait for the new one and
# assert the old one is gone in the same refresh.
expect(
page.locator(f'.file-tree-row-file[data-target-path="{new_name}"]')
).to_be_visible(timeout=5000)
expect(
page.locator('.file-tree-row-file[data-target-path="server.cfg"]')
).to_have_count(0)