left4me/l4d2web/tests
mwiegand 6b0231970c
feat(files): add GET /overlays/<id>/files/new + extend editor template
Step 5/12 of docs/superpowers/plans/2026-05-17-files-overlay-rewrite.md.

Adds a server-rendered editor page for creating a new file in a target
folder. Renders the same overlay_file_editor.html as the edit route,
but with is_new=True so the template:
  * Hides the Delete button
  * Hides the Download link (no file to download yet)
  * Changes the Save button label to "Create"
  * Emits data-at-folder on the textarea for the JS save handler to
    compose path = at_folder + "/" + filename
  * Updates the title block (browser tab + heading) to "New file" /
    "<at_folder>/…new file"

The existing edit route now passes is_new=False and at_folder=""
explicitly so both call sites are explicit about the contract.

Path validation: ?at may be empty (overlay root) or a relative folder
path. safe_resolve_for_listing rejects traversal attempts (400). A
missing or non-directory at returns 404. Reused the helper to keep
the safety story identical to the listing / edit routes.

Phase B Step 5 is server-side only — no JS changes here. Step 6
migrates openEditorTextNew in editor.js to use this route via
window.modals.openRouted().

Tests added (tests/test_url_addressable_modals.py):
  * test_new_route_renders_with_empty_content
  * test_new_route_renders_with_target_folder_attribute
  * test_new_route_renders_create_button_not_save
  * test_new_route_400s_for_invalid_at_path
  * test_new_route_404s_for_non_files_overlay

pytest: 573 → 578 passed, 1 skipped, 3 deselected.

Verified live: curl /overlays/2/files/new returns markup with
data-at-folder="", "UTF-8 · 0 bytes" byte count, save button label
"Create", and no Delete / Download buttons.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-17 16:03:01 +02:00
..
e2e test(editor-v2): Playwright e2e + Tab→acceptCompletion fix 2026-05-17 02:15:51 +02:00
__init__.py refactor(repo): uv workspace + hatchling + layout restructure 2026-05-15 22:04:29 +02:00
test_admin_users.py secure(l4d2web): block non-admin writes on system overlays; last-admin guard on deactivate 2026-05-14 22:24:19 +02:00
test_alembic_migrations.py feat(l4d2-web): script overlay schema — add overlay.script + last_build_status, drop globals tables 2026-05-08 15:33:04 +02:00
test_auth.py test(datetime): pin tz-aware contract for fixtures (red until UtcDateTime lands) 2026-05-16 11:55:48 +02:00
test_blueprints.py feat(editor-v2): wire data-editor-language attrs into three textareas 2026-05-17 02:06:58 +02:00
test_cli.py tests/cli: cover running+cancelling idempotency, tighten app-context scope 2026-05-11 23:18:54 +02:00
test_config.py config: allow SESSION_COOKIE_SECURE override and disable on test deploy 2026-05-07 00:56:48 +02:00
test_console_routes.py feat(l4d2-web): console panel UI on server detail page 2026-05-14 21:39:21 +02:00
test_health.py security: harden boundary inputs and production defaults 2026-05-07 00:53:33 +02:00
test_host_commands.py fix(l4d2-web): keep SSE log stream from pinning gunicorn threads 2026-05-08 11:18:56 +02:00
test_job_logs.py refactor(repo): uv workspace + hatchling + layout restructure 2026-05-15 22:04:29 +02:00
test_job_worker.py job_worker: don't duplicate streamed stderr on HostCommandError 2026-05-10 22:52:54 +02:00
test_l4d2_facade.py feat(l4d2-web): add hostname edit form to server detail page 2026-05-13 15:42:46 +02:00
test_live_state_poller.py test(datetime): pin tz-aware contract for fixtures (red until UtcDateTime lands) 2026-05-16 11:55:48 +02:00
test_migrations.py feat(live-state): add schema for snapshots, sessions, steam profiles 2026-05-12 21:18:24 +02:00
test_models.py refactor(datetime): introduce UtcDateTime, remove naive-strip workarounds 2026-05-16 11:59:29 +02:00
test_overlay_builders.py overlay_builders: restore symlink overwrite guards + nits 2026-05-11 23:01:38 +02:00
test_overlay_creation.py feat(l4d2-web): overlay path helpers and creation 2026-05-07 16:38:39 +02:00
test_overlay_files.py feat(files-overlay): user-managed file content as a third overlay type 2026-05-09 18:59:32 +02:00
test_overlay_files_routes.py secure(l4d2web): block non-admin writes on system overlays; last-admin guard on deactivate 2026-05-14 22:24:19 +02:00
test_overlays.py auth: reject sessions older than user.password_changed_at 2026-05-11 21:54:13 +02:00
test_pages.py refactor(repo): uv workspace + hatchling + layout restructure 2026-05-15 22:04:29 +02:00
test_profile.py tests/test_profile: hoist sqlalchemy import to module top 2026-05-11 22:01:29 +02:00
test_rate_limit.py rate-limit: extract generic helper, reuse from login 2026-05-11 21:45:51 +02:00
test_rcon.py feat(l4d2-web): add execute_command to rcon service with full test coverage 2026-05-14 21:21:41 +02:00
test_script_overlay_routes.py feat(editor-v2): wire data-editor-language attrs into three textareas 2026-05-17 02:06:58 +02:00
test_security.py fix(csp): allow workshop preview thumbnails from steamusercontent.com 2026-05-16 11:22:30 +02:00
test_seed_script_overlays.py feat(l4d2-web): seed example script overlays from examples/script-overlays/ 2026-05-08 18:41:08 +02:00
test_servers.py test(datetime): pin tz-aware contract for fixtures (red until UtcDateTime lands) 2026-05-16 11:55:48 +02:00
test_status_and_server_logs.py auth: reject sessions older than user.password_changed_at 2026-05-11 21:54:13 +02:00
test_steam_users.py feat(live-state): use Steam avatarfull (184x184), downscale in CSS 2026-05-12 23:17:51 +02:00
test_steam_workshop.py feat(l4d2-web): steam workshop API client and downloader 2026-05-07 16:37:39 +02:00
test_timeago.py feat(app): register timeago Jinja filter 2026-05-16 11:10:59 +02:00
test_url_addressable_modals.py feat(files): add GET /overlays/<id>/files/new + extend editor template 2026-05-17 16:03:01 +02:00
test_workshop_overlay_models.py feat(l4d2-web): script overlay schema — add overlay.script + last_build_status, drop globals tables 2026-05-08 15:33:04 +02:00
test_workshop_paths.py feat(l4d2-web): overlay path helpers and creation 2026-05-07 16:38:39 +02:00
test_workshop_routes.py workshop_routes: narrow refresh's steam exception handler 2026-05-11 23:08:41 +02:00