cronekorkn/left4me
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(l4d2-web): remove orphaned 'Global map overlays' admin section

Browse source 
The route /admin/global-overlays/refresh was removed with the script-overlays
rewrite (migration 0005 dropped the global_overlay_* tables; the systemd
refresh units were deleted from deploy/). The admin-page form was left
behind and would 404 on submit. Drop the section and lock it out with an
assertion in the existing admin-pages test.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
mwiegand 2026-05-08 17:25:15 +02:00
parent ebddb0fab2
commit 5e2c771276
No known key found for this signature in database
2 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
l4d2web/templates/admin.html
View file

@ -28,13 +28,4 @@
<button type="submit">Refresh all workshop items</button> <button type="submit">Refresh all workshop items</button>
</form> </form>
</section> </section>
<section class="panel">
<h2>Global map overlays</h2>
<p class="muted">Queue a refresh for managed L4D2Center and CEDAPUG map overlays.</p>
<form method="post" action="/admin/global-overlays/refresh">
<input type="hidden" name="csrf_token" value="{{ session.get('csrf_token', '') }}">
<button type="submit">Refresh global overlays</button>
</form>
</section>
{% endblock %} {% endblock %}

5
l4d2web/tests/test_pages.py
View file

@ -312,7 +312,10 @@ def test_admin_can_use_admin_pages(tmp_path, monkeypatch) -> None:
admin_page = client.get("/admin") admin_page = client.get("/admin")
assert admin_page.status_code == 200 assert admin_page.status_code == 200
assert 'action="/admin/install"' in admin_page.get_data(as_text=True) admin_html = admin_page.get_data(as_text=True)
assert 'action="/admin/install"' in admin_html
assert "/admin/global-overlays/refresh" not in admin_html
assert "Global map overlays" not in admin_html
assert client.get("/admin/users").status_code == 200 assert client.get("/admin/users").status_code == 200
jobs_response = client.get("/admin/jobs") jobs_response = client.get("/admin/jobs")
assert jobs_response.status_code == 200 assert jobs_response.status_code == 200