56f5c30296
Before this change there were two callers of left4me-overlay mount: the web app's start_instance (Python, in-process) and the unit's ExecStartPre (shell, via sudo). The duplication invited divergence; the helper's recently-added idempotency made both paths technically work but at the cost of a "first wins" race and dead-code retry logic in start_instance. Drop the in-process _mounter.mount() call from start_instance. The web app now only stages cfg files (which still must happen on the host filesystem before mount, to avoid overlayfs copy-up changing ownership), then asks systemd to enable+start the unit; the unit's ExecStartPre does the mount. Removed: - os.path.ismount(merged) refusal in start_instance and its test (test_start_refuses_to_double_mount). The race the check guarded against is now handled by the helper's idempotency. - _load_instance_env helper and the `os` import (both became dead). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| test_cli.py | ||
| test_initialize.py | ||
| test_install.py | ||
| test_kernel_overlayfs.py | ||
| test_lifecycle.py | ||
| test_logging.py | ||
| test_logs.py | ||
| test_overlay_helper.py | ||
| test_paths.py | ||
| test_process.py | ||
| test_service_control.py | ||
| test_spec.py | ||
| test_status.py | ||