Architectural problem flagged after the pilot: "the template renders both as a standalone page AND as a modal fragment" contract is non-obvious for future template authors. Task 2 originally used <dialog>, Task 8.5 had to undo that because nested <dialog> collapses to 2px. The convention is now in two places: 1. AGENTS.md gains a "URL-addressable modal templates" section under Non-Negotiable Constraints listing: outer element must be <div>, close buttons use data-modal-dismiss, form actions need #modal-content-scoped document delegation, modal chrome CSS is owned by the outer slot. 2. _modal_partial.html (the file template authors will most likely open when wondering "what's this layout?") carries a Jinja comment header summarising the rule + linking to AGENTS.md for the full convention. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
8.6 KiB
AGENTS.md
Guidance for coding agents working in this repository.
Mission
Build left4me according to the two implementation plans:
docs/superpowers/plans/2026-04-22-l4d2-host-lib-v1.mddocs/superpowers/plans/2026-04-23-l4d2-web-app-v1.md
Do not invent architecture outside these plans unless explicitly requested.
Current Project State
l4d2host/andl4d2web/implementation directories exist.- Implementation plans remain the source of truth for contract changes and task sequencing.
Non-Negotiable Constraints
Workspace and tools
- Do not use git worktrees.
- Repo is a uv workspace; Python is pinned to 3.13 via
.python-version. After fresh checkout: installuv(brew install uv/curl -LsSf https://astral.sh/uv/install.sh | sh), thendirenv allow(oruv syncdirectly). See README Local development for details.
URL-addressable modal templates
A template that renders both as a full standalone page AND as a modal fragment (i.e. {% extends base_layout %}, where base_layout resolves to _modal_partial.html for modal-mode requests and base.html otherwise — driven by the HX-Modal: 1 header in app.py:inject_base_layout) MUST follow these conventions:
- The outermost element of
{% block content %}is a<div>, NOT a<dialog>. The persistent<dialog id="modal-container">slot inbase.htmlprovides top-layer + backdrop + focus-trap + Esc-to-close semantics. Nested<dialog>elements collapse to 2 px in every browser — Task 8.5 of the modals pilot fixed this the hard way; do not re-introduce it. In standalone mode, the content renders flat under<main>, which is the intended "this URL is a real page, not a modal-over-nothing" UX. - Close buttons use
data-modal-dismiss(NOTdata-modal-close— that's the legacy inline-dialog system).modal-router.jslistens at document level for this attribute and callsdialog.close()on the outer slot. - Form-bearing content needs document-level event delegation for submit/save/delete actions, gated on
event.target.closest("#modal-content"). Direct binding to elements in the swapped-in fragment only works in standalone mode — HTMX-swapped content arrives as fresh DOM nodes with no listeners attached. Seefiles-overlay.jslines ~599-641 for the canonical pattern (readdata-*attributes from the textarea, NOT from JS state set during open). - CSS classes targeting modal chrome are scoped to the outer slot —
dialog.modal, div.modalincomponents.css. The inner content div should NOT carryclass="modal modal-wide"(that's what painted card-in-a-card during Task 8.5b; the outer dialog owns chrome). - Reference:
docs/superpowers/specs/2026-05-17-url-addressable-modals-design.md(design + verification matrix) and the plan errata at the top ofdocs/superpowers/plans/2026-05-17-url-addressable-modals.md.
Dev server and filesystem paths
- Production paths (
/var/lib/left4me,/usr/local/lib/systemd/system,/usr/local/libexec/left4me,/etc/left4me) exist only on Linux deploy hosts. Never create or write to these on a developer machine. They are referenced inl4d2host/l4d2host/paths.pyand the spec only as the production layout. - For local dev, always use
scripts/dev-server.py. It setsLEFT4ME_ROOT=./.tmp/dev-server, runs migrations, seeds demo content (admin + blueprint + script overlay + files overlay), and starts Flask on port 5051. Reset state withrm -rf .tmp/dev-serverthen re-run. Never invokeflask rundirectly — that leavesLEFT4ME_ROOTunset and the app falls back to the production/var/lib/left4me, which on macOS surfaces as "route returns 404 / empty modal / file not found" and can be mistaken for a code bug. - All ephemeral dev state lives under
.tmp/(gitignored). Use$TMPDIRonly for transient files outside the repo. Do NOT use/tmp,~/Library/Application Support, or any system path for project state — only.tmp/(project-local) or$TMPDIR(sandbox-blessed). - Symptom-to-cause translation: if a route returns 404 or behaves as if the filesystem is empty, the first diagnosis is "
LEFT4ME_ROOTis wrong" (defaulted to the production path), not "code bug." Restart viascripts/dev-server.py.
Planning artifacts
- Design specs live in
docs/superpowers/specs/asYYYY-MM-DD-<topic>-design.md. - Implementation plans live in
docs/superpowers/plans/asYYYY-MM-DD-<topic>.md(suffix the topic with-v1/-v2/etc. if a plan is versioned). - Commit both to git as soon as the user approves them.
- Do not leave specs or plans outside this repo. The
~/.claude/plans/<slug>.mdplan-mode scratch file is acceptable while plan mode is open; the persisted artifact must end up underdocs/superpowers/and be committed.
Naming and boundaries
- Use
l4d2naming consistently. - Keep host library and web app as separate components.
- Do not collapse them into one package.
Host library (l4d2host / l4d2ctl)
- Exposed CLI write command set is fixed:
installinitialize <name> -f <spec.yaml>start <name>stop <name>delete <name>
- CLI read commands are allowed for web/host boundary consistency:
status <name> --jsonlogs <name> --lines <n> --follow/--no-follow
- Runtime paths are rooted at
LEFT4ME_ROOT, defaulting to/var/lib/left4me. - Deployment/config management owns global units under
/usr/local/lib/systemd/systemand privileged helpers under/usr/local/libexec/left4me. - Overlay directories are populated by the web app (workshop downloads, managed-global refresh). The host library only mounts them.
- Fail-fast subprocess behavior; pass raw stderr; propagate return code.
- No lock manager, no rollback, no preflight runtime checks.
- Delete missing instance/runtime dirs must succeed (no-op).
- Read APIs required for web app integration:
get_instance_status(name)stream_instance_logs(name, lines=200, follow=True)
Web app (l4d2-web-app)
- Flask + server-rendered templates + vendored HTMX.
- No external frontend framework/dependencies.
- Custom CSS with tokenized, consistent link and accent colors.
- Local username/password auth and
adminflag. - Persist command logs in
job_logstable (retain indefinitely). - Desired vs actual server state model.
- Live logs in UI for both jobs and servers.
- Web app host operations go through
l4d2ctlvia a host command client, not directl4d2hostimports. - Blueprint semantics (locked):
- private per user in v1
- live-linked to servers
- no server-level overrides
- deleting in-use blueprint is blocked
- updates apply on next action
- servers can reassign blueprint anytime
Delivery Workflow
- Read both plan files fully before coding.
- Execute plan tasks in order.
- Keep changes scoped to one task at a time.
- Run task-level tests before moving forward.
- Do not claim completion without command evidence.
- Keep docs updated when behavior/contracts change.
Verification Expectations
Before claiming success on any step, run the relevant command and report actual output status.
Typical commands (once components exist):
pytest l4d2host/tests -qpytest l4d2web/tests -q
Change Control
- If a requested change conflicts with this file, follow explicit user instruction.
- If plans and code diverge, update plans or flag the mismatch clearly.
End-to-end tests
The Playwright-based browser tests under l4d2web/tests/e2e/ need a
chromium binary, fetched on first setup:
uv run playwright install chromium
Always invoke as uv run pytest -m e2e ... (excluded from the default
fast suite via the e2e marker). Other forms crash Chromium under the
macOS sandbox; only this exact invocation is exempt.
Editor bundle (CodeMirror 6)
The in-browser code editor on the blueprint config / overlay script /
files-modal textareas is bundled from l4d2web/scripts/editor-src/
via esbuild and committed pre-built to
l4d2web/l4d2web/static/vendor/editor.bundle.js. Source lives under
l4d2web/scripts/editor-src/; design and plan at
docs/superpowers/specs/2026-05-17-textarea-editor-v2-design.md and
docs/superpowers/plans/2026-05-17-textarea-editor-v2.md.
Rebuild after editing the source:
./l4d2web/scripts/build-editor.sh
Requires node + npm locally. The script overrides the npm cache to
$TMPDIR/npm-cache (set NPM_CACHE to override) to dodge root-owned
files in ~/.npm/_cacache/ from older npm versions. Commit the
regenerated editor.bundle.js, editor.bundle.css, and
editor.bundle.sha256 alongside any source change.
Regenerate the autocomplete vocab from ./cvar_list (live L4D2
cvarlist dump committed at repo root) after replacing the dump:
./l4d2web/scripts/build-vocab.py